Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ra-data-graphql-simple dependency (fix #7654) #7787

Closed
wants to merge 5 commits into from

Conversation

arjunyel
Copy link
Contributor

@arjunyel arjunyel commented Jun 4, 2022

Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll request a second review for this PR, but everything seems good to me!
Thanks!

@slax57 slax57 requested a review from djhi June 14, 2022 12:31
@slax57
Copy link
Contributor

slax57 commented Jun 15, 2022

Btw, could you please rebase your branch onto the latest version (github says it has some conflicts), and also bump the RA versions to ^4.1.3 rather than ^4.1.2?
(sorry it's my bad for taking so long to review your PR, as you can guess we've been quite busy 😅 )
Thanks

@arjunyel arjunyel closed this Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ra-data-graphql-simple npm install fails
3 participants